[libvirt] [PATCH 4/5] vcpuinfo: add the code to fallback to try new API

Eric Blake eblake at redhat.com
Fri Jun 24 21:59:57 UTC 2011


On 06/24/2011 03:01 AM, Taku Izumi wrote:
> 
> The "virsh vcpuinfo" command results in failure when the target domain
> is inactive on KVM. This patch improves this behavior by adding the
> fallback to invoke virDomainGetVcpupinInfo API in case of 
> virDomainGetVcpus API returns error and the target domain is inactive.
> 
> 
> Signd-off-by: Taku Izumi <izumi.taku at jp.fujitsu.com>

s/Signd/Signed/

[unlike the kernel folks, we aren't sticklers about S-O-B lines on this
list, but if you use it, you might as well use it correctly ;)]

ACK as-is!

> +        if (info.state == VIR_DOMAIN_SHUTOFF &&
> +            (ncpus = virDomainGetVcpupinInfo(dom, info.nrVirtCpu,

Well, there's the s/Vcpupin/VcpuPin/ change coming up later, but it has
wider-reaching effects, so I'll leave it separate.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110624/df21efdd/attachment-0001.sig>


More information about the libvir-list mailing list