[libvirt] [PATCH 4/4] build: avoid double-close bug with pipe2
Daniel P. Berrange
berrange at redhat.com
Thu Jun 30 14:24:33 UTC 2011
On Thu, Jun 30, 2011 at 08:14:56AM -0600, Eric Blake wrote:
> Based on Coverity's finding on the previous patch, I audited
> gnulib's pipe2 code and found that we had the potential for
> a subtle double-close bug, unless gnulib guarantees that the
> contents of the fd array are unchanged on pipe2() failure.
>
> * .gnulib: Update to latest, for pipe2 fix.
> ---
> .gnulib | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/.gnulib b/.gnulib
> index cbfd25f..7269b35 160000
> --- a/.gnulib
> +++ b/.gnulib
> @@ -1 +1 @@
> -Subproject commit cbfd25f0edf5f4b853e8ed2e01a4782ec80faba2
> +Subproject commit 7269b35c8d9be1a6f97906b9e29b8c422b92fc31
ACK
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list