[libvirt] [PATCH] virsh: Add daemon version reporting

Eric Blake eblake at redhat.com
Mon Jun 6 13:56:01 UTC 2011


On 06/06/2011 06:17 AM, Daniel P. Berrange wrote:
>> +
>> +    ret = virConnectGetLibVersion(ctl->conn, &daemonVersion);
>> +    if (ret < 0) {
>> +        vshError(ctl, "%s", _("failed to get the daemon version"));
>> +        return false;
> 
> Raising an error here will prevent virsh talking to any
> libvirtd < 0.7.3

Also, this changes virsh output, which might break existing scripts.  It
would be safer to introduce a new bool flag, 'virsh version --daemon',
to specifically request the new output line.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110606/a0a316f9/attachment-0001.sig>


More information about the libvir-list mailing list