[libvirt] [PATCH 08/10 V2] send-key: Implementing the remote protocol

Eric Blake eblake at redhat.com
Tue Jun 14 19:29:24 UTC 2011


On 06/13/2011 04:56 PM, Daniel P. Berrange wrote:
> On Tue, Jun 07, 2011 at 05:11:15PM +0800, Lai Jiangshan wrote:
>> Signed-off-by: Lai Jiangshan <laijs at cn.fujitsu.com>
>> ---
>>  src/remote/remote_driver.c   |    1 +
>>  src/remote/remote_protocol.x |   16 +++++++++++++++-
>>  src/remote_protocol-structs  |   11 +++++++++++
>>  3 files changed, 27 insertions(+), 1 deletions(-)
>>
>> +/*
>> + * Max number of sending keycodes.
>> + */
>> +const REMOTE_SEND_KEY_MAX = 16;
> 
> Should call this  REMOTE_DOMAIN_SEND_KEY_MAX really
> 
> 
> ACK with the minor constant rename.

I rebased this and made that name change, fixed the fallout from 'make
check' (remote_protocol-structs uses 'u_int', not 'unsigned int', due to
the way pdwtags works, and your whitespace was off; but you only notice
that if you have the dwarves package installed), and pushed.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110614/b1a523aa/attachment-0001.sig>


More information about the libvir-list mailing list