[libvirt] [PATCH] virsh: avoid bogus description
Eric Blake
eblake at redhat.com
Tue Jun 21 17:54:28 UTC 2011
On 06/20/2011 08:22 PM, Wen Congyang wrote:
>> +++ b/tools/virsh.c
>> @@ -12113,7 +12113,8 @@ vshCmddefHelp(vshControl *ctl, const char *cmdname)
>> vshError(ctl, _("command '%s' doesn't exist"), cmdname);
>> return false;
>> } else {
>> - const char *desc = _(vshCmddefGetInfo(def, "desc"));
>> + /* Don't translate desc until after we know it isn't "". */
>
> Can two prepositions use together?
As a native speaker, I didn't notice anything wrong with that use
(actually, I might have inserted "that" between "know it"), but I used a
shorter phrase altogether that should be easier to parse:
/* Don't translate desc if it is "". */
>
> ACK except the comment.
Now pushed.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110621/5fc2b811/attachment-0001.sig>
More information about the libvir-list
mailing list