[libvirt] [PATCH 7/9] Avoid referencing NULL pointer when copying stream error

Eric Blake eblake at redhat.com
Tue Jun 28 18:05:28 UTC 2011


On 06/28/2011 11:01 AM, Daniel P. Berrange wrote:
> * src/rpc/virnetclientstream.c: Avoid referencing NULL
> ---
>  src/rpc/virnetclientstream.c |   21 ++++++++++++++++-----
>  1 files changed, 16 insertions(+), 5 deletions(-)
> 
> diff --git a/src/rpc/virnetclientstream.c b/src/rpc/virnetclientstream.c
> index 44c9acf..99c7b41 100644
> --- a/src/rpc/virnetclientstream.c
> +++ b/src/rpc/virnetclientstream.c
> @@ -217,13 +217,24 @@ int virNetClientStreamSetError(virNetClientStreamPtr st,
>      } else {
>          st->err.code = err.code;
>      }
> -    st->err.message = *err.message;
> -    *err.message = NULL;
> +    if (err.message) {
> +        st->err.message = *err.message;
> +        *err.message = NULL;
> +    }

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110628/0f5ba9e6/attachment-0001.sig>


More information about the libvir-list mailing list