[libvirt] [PATCHv2] build: consistently use CFLAGS

[Laine Stump]

On 06/30/2011 07:12 PM, Laine Stump wrote:
> On 06/30/2011 02:09 PM, Eric Blake wrote:
>> According to the automake manual, CPPFLAGS (aka INCLUDES, as spelled
>> in automake 1.9.6) should only include -I, -D, and -U directives; more
>> generic directives like -Wall belong in CFLAGS since they affect more
>> phases of the build process.  Therefore, we should be sticking CFLAGS
>> additions into a CFLAGS container, not a CPPFLAGS container.
>>
>> * src/Makefile.am (INCLUDES): Move CFLAGS items...
>> (AM_CFLAGS): ...to their proper location.
>> * python/Makefile.am (INCLUDES, AM_CFLAGS): Likewise.
>> * tests/Makefile.am (INCLUDES, AM_CFLAGS): Likewise.
>> ---
>
> ACK.

I spoke too soon - this patch causes /usr/include/libxml2 to be lost 
from the include path, which breaks the build.