[libvirt] [PATCHv2] unlock eventLoop before calling callback function

Eric Blake eblake at redhat.com
Mon Mar 7 17:36:15 UTC 2011


On 03/07/2011 10:18 AM, Daniel P. Berrange wrote:
> On Mon, Mar 07, 2011 at 10:09:36AM -0700, Eric Blake wrote:
>> From: Wen Congyang <wency at cn.fujitsu.com>
>>
>> When I use newest libvirt to save a domain, libvirtd will be deadlock.
>>
>> The reason is that we will try to lock some object in callback function, and we may call event API with locking the same object.
>> In the function virEventDispatchHandles(), we unlock eventLoop before calling callback function. I think we should
>> do the same thing in the function virEventCleanupTimeouts() and virEventCleanupHandles().
>>
>> Signed-off-by: Wen Congyang <wency at cn.fujitsu.com>
>> Signed-off-by: Eric Blake <eblake at redhat.com>
>> ---
>>
>> v2: incorporate comments from reviewers, and rebase on top of file move
>>
> 
> ACK

Thanks; pushed.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110307/16a03af3/attachment-0001.sig>


More information about the libvir-list mailing list