[libvirt] [PATCH 1/2] virsh: Remove indirect link against libxml2

[Guido Günther]

On Tue, Mar 08, 2011 at 06:57:22PM +0000, Daniel P. Berrange wrote:
> On Tue, Mar 08, 2011 at 07:36:00PM +0100, Guido Günther wrote:
> > as described at
> > http://wiki.debian.org/ToolChain/DSOLinking
> > https://fedoraproject.org/wiki/UnderstandingDSOLinkChange
> > 
> > otherwise the build fails on current Debian unstable with:
> > 
> > CCLD   virsh
> > /usr/bin/ld: virsh-virsh.o: undefined reference to symbol 'xmlSaveTree@@LIBXML2_2.6.8'
> > /usr/bin/ld: note: 'xmlSaveTree@@LIBXML2_2.6.8' is defined in DSO //usr/lib/libxml2.so.2 so try adding it to the linker command line
> > //usr/lib/libxml2.so.2: could not read symbols: Invalid operation
> > 
> > O.k. to apply?
> >  -- Guido
> > 
> > ---
> >  tools/Makefile.am |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/tools/Makefile.am b/tools/Makefile.am
> > index 68471ea..3e31dbd 100644
> > --- a/tools/Makefile.am
> > +++ b/tools/Makefile.am
> > @@ -47,6 +47,7 @@ virsh_LDADD =							\
> >  		../src/libvirt.la				\
> >  		../src/libvirt-qemu.la				\
> >  		../gnulib/lib/libgnu.la				\
> > +		$(LIBXML_LIBS)					\
> >  		$(VIRSH_LIBS)
> >  virsh_CFLAGS =							\
> >  		-I$(top_srcdir)/gnulib/lib -I../gnulib/lib	\
> 
> ACK
Pushed. Thanks,
 -- Guido