[libvirt] [PATCH 2/2] libvirtd: Remove indirect linking

[Guido Günther]

On Tue, Mar 08, 2011 at 06:57:02PM +0000, Daniel P. Berrange wrote:
[..snip..] 
> > -libvirtd_LDADD += ../src/libvirt.la
> > +if WITH_SECDRIVER_SELINUX
> > +    libvirtd_LDADD += $(SELINUX_LIBS)
> > +endif
> > +if WITH_SECDRIVER_APPARMOR
> > +    libvirtd_LDADD += $(APPARMOR_LIBS)
> > +endif
> > +
> > +libvirtd_LDADD += ../src/libvirt.la \
> > +                  $(CAPNG_LIBS)
> 
> This isn't correct. The individual drivers which uses these libraries
> should be specifying them in their LDADD in src/Makefile.am. Then libvirtd
> gets the link when libtool adds the drivers.
I took the above path since we otherwise have to add this in several
places. Does the attached version look better?`
Cheers,
 -- Guido
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-libvirtd-Remove-indirect-linking.patch
Type: text/x-diff
Size: 2765 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110308/0a896cd5/attachment-0001.bin>