[libvirt] Fix cygwin build
Daniel Veillard
veillard at redhat.com
Wed Mar 9 00:25:19 UTC 2011
On Tue, Mar 08, 2011 at 08:12:31AM -0700, Eric Blake wrote:
> On 03/08/2011 01:07 AM, Daniel Veillard wrote:
> > In virLogEmergencyDumpAll I was using SIGBUS and SIGUSR2, and
> > apparently they arent; defined on cygwin signal.h header.
>
> Huh? Cygwin has all 32 traditional Unix signals, including SIGBUS and
> SIGUSR2; it's only flaw is that it lacks the POSIX-required minimum of 8
> real-time signals (on cygwin, SIGRTMIN==SIGRTMAX). To my knowledge,
> mingw is the only modern porting target that lacks signals not required
> by C99.
>
> > I decided to
> > make the code conditional for all of them and not just those two for
> > portability sake. I resisted doing this on the daemon side because as
> > far as I know we don't compile it on WIN32. So I just pushed the
> > following under the build breaking rule,
>
> Well, it does fix mingw; so it was only the subject line that was
> misleading. :)
Ah, I probably confused the two :-)
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel at veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
More information about the libvir-list
mailing list