[libvirt] [PATCH] Include stdint.h in libvirt.h for INT64_MAX

[Matthias Bolte]

2011/3/9 Daniel Veillard <veillard at redhat.com>:
> On Wed, Mar 09, 2011 at 12:18:44PM +0000, Daniel P. Berrange wrote:
>> On Wed, Mar 09, 2011 at 10:49:34AM +0100, Matthias Bolte wrote:
>> > I found this one while trying to compile ruby-libvirt.
>> >
>> > Matthias
>>
>> > From 6858713a7ea7fad961acbc4d4f3c0c53ede2302d Mon Sep 17 00:00:00 2001
>> > From: Matthias Bolte <matthias.bolte at googlemail.com>
>> > Date: Wed, 9 Mar 2011 10:42:49 +0100
>> > Subject: [PATCH] Include stdint.h in libvirt.h for INT64_MAX
>> >
>> > VIR_DOMAIN_MEMORY_PARAM_UNLIMITED uses INT64_MAX but stdint.h
>> > was not included. Therefore, libvirt.h was not selfcontained.
>>
>> I'm a little wary of doing this, because stdint.h isn't neccessary
>> the most portable header file & while libvirt internally can rely
>> on gnulib to fix problems, apps building against libvirt don't
>> have that.
>>
>> I think it could be better to just define VIR_DOMAIN_MEMORY_PARAM_UNLIMITED
>> directly to the right value, rather than in terms of INT64_MAX
>
>  Agreed we should try to limit the dependancies from public headers
> to the minimum, in that case I'm fine hardcoding the value.
>
> Daniel
>

Okay, so here's v2.

Matthias
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Don-t-use-INT64_MAX-in-libvirt.h-because-it-requires.patch
Type: text/x-diff
Size: 1028 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110309/0bc10e48/attachment-0001.bin>