[libvirt] [RFC PATCHv4 15/15] qemu: support fd: migration with compression

[Paolo Bonzini]

On 03/10/2011 03:18 AM, Eric Blake wrote:
> +        if (qemuCaps&&  qemuCapsGet(qemuCaps, QEMU_CAPS_MIGRATE_QEMU_FD)&&
> +            priv->monConfig->type == VIR_DOMAIN_CHR_TYPE_UNIX) {
> +            cmd = virCommandNewArgs(args);
> +            virCommandSetInputFD(cmd, pipeFD[0]);
> +            virCommandSetOutputFD(cmd,&fd);

Should pipeFD[1] get cloexec treatment?

> +            if (virCommandRunAsync(cmd, NULL)<  0) {
> +                qemuDomainObjExitMonitorWithDriver(driver, vm);
> +                goto cleanup;
> +            }
> +            rc = qemuMonitorMigrateToFd(priv->mon,
> +                                        QEMU_MONITOR_MIGRATE_BACKGROUND,
> +                                        pipeFD[1]);

Paolo