[libvirt] [PATCH 3/4] libvirt-guest.init: declare variables as local
Eric Blake
eblake at redhat.com
Fri Mar 11 14:10:42 UTC 2011
On 03/09/2011 02:01 AM, Philipp Hahn wrote:
> Declare variables used in function only as local.
>
> Signed-off-by: Philipp Hahn <hahn at univention.de>
> ---
> tools/libvirt-guests.init.sh | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/tools/libvirt-guests.init.sh b/tools/libvirt-guests.init.sh
> index ab2b907..8da7576 100644
> --- a/tools/libvirt-guests.init.sh
> +++ b/tools/libvirt-guests.init.sh
> @@ -62,6 +62,7 @@ retval() {
> }
>
> run_virsh() {
> + local uri
NACK. local is not required by POSIX, therefore it is not portable.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110311/761e1a22/attachment-0001.sig>
More information about the libvir-list
mailing list