[libvirt] [PATCH] qemu: fix -global argument usage

Eric Blake eblake at redhat.com
Fri Mar 11 17:05:02 UTC 2011


* src/qemu/qemu_command.c (qemuBuildCommandLine): Pass two
separate arguments, and fix indentation.
---

I debated about pushing under the trivial rule, but restrained myself.

 src/qemu/qemu_command.c |   13 +++++++------
 1 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 0fc466c..8ca656a 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -4042,12 +4042,13 @@ qemuBuildCommandLine(virConnectPtr conn,
                 if (def->videos[0]->type == VIR_DOMAIN_VIDEO_TYPE_QXL) {
                     if (def->videos[0]->vram &&
                         qemuCapsGet(qemuCaps, QEMU_CAPS_DEVICE)) {
-                            if (qemuCapsGet(qemuCaps, QEMU_CAPS_DEVICE_QXL_VGA))
-                                virCommandAddArgFormat(cmd, "-global qxl-vga.vram_size=%u",
-                                                       def->videos[0]->vram * 1024);
-                            else
-                                virCommandAddArgFormat(cmd, "-global qxl.vram_size=%u",
-                                                       def->videos[0]->vram * 1024);
+                        virCommandAddArg(cmd, "-global");
+                        if (qemuCapsGet(qemuCaps, QEMU_CAPS_DEVICE_QXL_VGA))
+                            virCommandAddArgFormat(cmd, "qxl-vga.vram_size=%u",
+                                                   def->videos[0]->vram * 1024);
+                        else
+                            virCommandAddArgFormat(cmd, "qxl.vram_size=%u",
+                                                   def->videos[0]->vram * 1024);
                     }
                 }
             }
-- 
1.7.4




More information about the libvir-list mailing list