[libvirt] [PATCH] libvirt-guests: avoid globbing when splitting $URIS

Philipp Hahn hahn at univention.de
Mon Mar 14 07:37:21 UTC 2011


Hello Eric,

Am Freitag 11 März 2011 22:08:33 schrieb Eric Blake:
> * tools/libvirt-guests.init.sh (start, stop, gueststatus): Avoid
> shell globbing, since valid URIs can contain '?'.

Looks sane, but perhaps setting 'set -f' once at the top of the file with some 
comment would fix the problem as well, but that's just a question of 
personally preferred style.

Sincerely
Philipp Hahn
-- 
Philipp Hahn           Open Source Software Engineer      hahn at univention.de
Univention GmbH        Linux for Your Business        fon: +49 421 22 232- 0
Mary-Somerville-Str.1  D-28359 Bremen                 fax: +49 421 22 232-99
                                                   http://www.univention.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110314/b8ade83e/attachment-0001.sig>


More information about the libvir-list mailing list