[libvirt] [PATCH 1/2] qemu: Detect support for HMP passthrough

[Eric Blake]

On 03/17/2011 09:00 AM, Jiri Denemark wrote:
> ---
>  src/qemu/qemu_monitor.c      |   14 ++++++++++++--
>  src/qemu/qemu_monitor.h      |    2 ++
>  src/qemu/qemu_monitor_json.c |   42 ++++++++++++++++++++++++++++++++++++++++++
>  src/qemu/qemu_monitor_json.h |    2 ++
>  4 files changed, 58 insertions(+), 2 deletions(-)
> 

> +++ b/src/qemu/qemu_monitor.h
> @@ -127,6 +127,8 @@ void qemuMonitorClose(qemuMonitorPtr mon);
>  
>  int qemuMonitorSetCapabilities(qemuMonitorPtr mon);
>  
> +int qemuMonitorCheckHMP(qemuMonitorPtr mon);
> +

Do we need code in qemu_driver.c:qemuDomainMonitorCommand to make 'virsh
qemu-monitor-command --hmp' get a nice error message when
qemuMonitorCheckHMP fails, or is that error message already sufficient?

Depending on the answer to that question, ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110317/a29f5098/attachment-0001.sig>