[libvirt] [PATCH 1/2] util: guarantee sane errno in virFileIsExecutable
Eric Blake
eblake at redhat.com
Mon Mar 21 15:27:38 UTC 2011
On 03/19/2011 07:54 AM, Matthias Bolte wrote:
> 2011/3/18 Eric Blake <eblake at redhat.com>:
>> If virFileIsExecutable is to replace access(file,X_OK), then
>> errno must be usable on failure.
>>
>> * src/util/util.c (virFileIsExecutable): Set errno on failure.
>> ---
>>
>
> ACK.
Thanks; pushed. Did you also get to look at patch 2 in the series,
including the question of whether virFileIsExecutable should be checking
access(file,R_OK|X_OK) for the purpose of executing shell scripts?
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110321/1592db52/attachment-0001.sig>
More information about the libvir-list
mailing list