[libvirt] [PATCH] v2: Fix uninitialized variable & error reporting in LXC veth setup

Eric Blake eblake at redhat.com
Mon Mar 21 17:49:30 UTC 2011


On 03/21/2011 09:37 AM, Daniel P. Berrange wrote:
> THe veth setup in LXC had a couple of flaws, first brInit did

s/THe/The/

> not report any error when it failed. Second vethCreate() did
> not correctly initialize the variable containing the return
> code, so could report failure even when it succeeded.
> 
> * src/lxc/lxc_driver.c: Report error when brInit fails
> * src/lxc/veth.c: Fix uninitialized variable
> ---
>  src/lxc/lxc_driver.c |    8 ++++++--
>  src/lxc/veth.c       |   33 ++++++++++++++++++++++-----------
>  2 files changed, 28 insertions(+), 13 deletions(-)

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110321/c63c8f5c/attachment-0001.sig>


More information about the libvir-list mailing list