[libvirt] [PATCH 6/6] Fix infinite loop in daemon if client quits with multiple streams open

Eric Blake eblake at redhat.com
Mon Mar 21 21:38:55 UTC 2011


On 03/18/2011 10:36 AM, Daniel P. Berrange wrote:
> The daemon loops over the linked list of streams when a client
> quits, closing any that the client hadn't already closed. Except
> it didn't ever move to the next element in the list!
> 
> * daemon/stream.c: Fix loop over linked list of streams
> ---
>  daemon/stream.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/daemon/stream.c b/daemon/stream.c
> index 967aea2..b94e3df 100644
> --- a/daemon/stream.c
> +++ b/daemon/stream.c
> @@ -343,6 +343,7 @@ remoteRemoveClientStream(struct qemud_client *client,
>                  filter->next = filter->next->next;
>                  break;
>              }
> +            filter = filter->next;

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110321/760ed4ba/attachment-0001.sig>


More information about the libvir-list mailing list