[libvirt] [PATCH 4/6] Support volume data upload/download APIs in storage driver

Eric Blake eblake at redhat.com
Thu Mar 24 23:31:38 UTC 2011


On 03/23/2011 11:36 AM, Daniel P. Berrange wrote:
> Use generic FD streams to allow data upload/download to/from
> any storage volume
> 
> * src/storage/storage_driver.c: Wire up upload/download APIs
> ---
>  src/storage/storage_driver.c |  132 +++++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 130 insertions(+), 2 deletions(-)

ACK.

> +
> +    /* Not using O_CREAT because the file is required to
> +     * already exist at this point */
> +    if (virFDStreamOpenFile(stream,
> +                            vol->target.path,
> +                            offset, length,
> +                            O_WRONLY) < 0)

This won't work with root-squash NFS volumes, but that can be a later fixup.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110324/7fb91a45/attachment-0001.sig>


More information about the libvir-list mailing list