[libvirt] [libvirt-php] Add lookup function for pool & volume

Michal Novotny minovotn at redhat.com
Mon Mar 28 09:24:11 UTC 2011


Hi Lyre,

> +		set_error ("Cannot find storage pool" TSRMLS_CC);


This is being set by the function itself and caught using the
catch_error() so please avoid this line in v2 of the patch.


> +	volume=virStorageVolLookupByPath (conn->conn,name);
> +	if (volume==NULL)
> +	{
> +		set_error ("Cannot find volume");
> +		RETURN_FALSE;
> +	}


Same here.

Thanks,
Michal

-- 
Michal Novotny <minovotn at redhat.com>, RHCE
Virtualization Team (xen userspace), Red Hat




More information about the libvir-list mailing list