[libvirt] [PATCH 2/8 v2] cputune: Add document for cputune xml
Daniel Veillard
veillard at redhat.com
Tue Mar 29 09:22:13 UTC 2011
On Tue, Mar 29, 2011 at 04:49:50PM +0800, Osier Yang wrote:
> ---
> docs/formatdomain.html.in | 20 ++++++++++++++++++++
> 1 files changed, 20 insertions(+), 0 deletions(-)
>
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 64b0b74..3375fe9 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -346,6 +346,26 @@
> be used to specify whether fewer than the maximum number of
> virtual CPUs should be enabled.
> </dd>
> + <dt><code>cputune</code></dt>
> + <dd> The optional <code>cputune</code> element provides details
> + regarding the cpu tunable parameters for the domain.</dd>
> + <dt><code>vcpupin</code></dt>
> + <dd> The optional <code>vcpupin</code> element specifies which of host
> + physical CPUS the domain VCPU will be pinned to. If this is ommited,
> + each VCPU pinned to all the physical CPUS by default. It contains two
> + required attributes, the attribute <code>vcpu</vcpu> specifies vcpu id,
> + and the attribute <code>cpuset</code> is same as attribute <code>cpuset</code>
> + of element <code>vcpu</code>. NB, Only qemu driver supports</dd>
> + <dt><code>shares</code></dt>
> + <dd> The optional <code>shares</code> element specifies the proportional
> + weighted share for the domain. If this is ommited, it defaults to
> + the OS provided defaults.
up to here, okay,
> .... NB, only qemu and LXC driver support,
> + and the value has a valid value range of 0-262144; Negative values
> + are wrapped to positive, and larger values are capped at the maximum.
> + Therefore, -1 is a useful shorthand for 262144;
NACK to this part, as Matthias pointed out, 262144 restriction need to go
(one may explain that it's an arbitrary limit on QEmu and LXC hypervisors
though).
> ... There is no unit for
> + the value, it's a relative measure based on the setting of other VM,
> + e.g. A VM configured with value 2048 will get twice as much CPU time as
> + a VM configured with value 1024.</dd>
okay for the remainer, which is the real explanation.
ACK for a patch consisting of the first and last part, ommiting the
middle one.
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel at veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
More information about the libvir-list
mailing list