[libvirt] [PATCH] free tmp after unlinking it
Daniel P. Berrange
berrange at redhat.com
Thu Mar 31 10:49:07 UTC 2011
On Thu, Mar 31, 2011 at 04:23:33PM +0800, Wen Congyang wrote:
> ---
> src/qemu/qemu_driver.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index dd12dc8..5aa715e 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -5065,9 +5065,9 @@ endjob:
> vm = NULL;
>
> cleanup:
> - VIR_FREE(tmp);
> VIR_FORCE_CLOSE(fd);
> unlink (tmp);
> + VIR_FREE(tmp);
> if (vm)
> virDomainObjUnlock(vm);
> return ret;
ACK, but can you write a bit of a longer commit message
saying what area of code / method this is fixing, because
the diff context is not showing the method name.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list