[libvirt] [PATCH 2/2] Network: Add support for DNS hosts definition

[Paolo Bonzini]

On 03/31/2011 01:06 PM, Michal Novotny wrote:
>> >  - this would be the third patch in the series, and it would add
>> >  dnsmasqAddHost calls in networkSaveDnsmasqHostsfile
> So this patch will be just adding the networkSaveDnsmasqHostsfile() call
> to the dnsmasqAddHost() and nothing else ?

And all the XML processing.

>>> >>  diff --git a/tests/networkxml2xmlin/nat-network-dns-hosts.xml b/tests/networkxml2xmlin/nat-network-dns-hosts.xml
>>> >>  new file mode 100644
>>> >>  index 0000000..fe545cf
>> >  Uhm, libvirt has no tests that actually check whether the dnsmasq
>> >  command line works?  That's a bit bad, perhaps you can add them...
> Well, unfortunately there are no tests to check whether the dnsmasq
> command line works. What would you prefer? To run it with some bogus PID
> file and port and check the command execution error code and if it's 0
> (and PID is working) then to kill $PID and make the test pass, otherwise
> fail the test or something similar?

Even a regression test that compares the command-line with what is in a 
file, would be great.

Regarding all other questions, I suggest you start by studying 
src/util/dnsmasq.c and how it is used.

Paolo