[libvirt] [PATCH] storage: use virCommand to avoid compiler warning

Laine Stump laine at laine.org
Wed May 4 04:32:47 UTC 2011


On 05/03/2011 06:14 PM, Eric Blake wrote:
> clang didn't like the last increment to nargs.  But why even
> track nargs ourselves, when virCommand does it for us?
>
> * src/storage/storage_backend_iscsi.c
> (virStorageBackendISCSIConnection): Switch to virCommand to avoid
> a dead-store warning on nargs.
> ---
>   src/storage/storage_backend_iscsi.c |   36 ++++++++--------------------------
>   1 files changed, 9 insertions(+), 27 deletions(-)

ACK. It really is nice how much cruft is removed when switching to 
virCommand!




More information about the libvir-list mailing list