[libvirt] [PATCH] maint: avoid comparisons to bool constants
Matthias Bolte
matthias.bolte at googlemail.com
Fri May 6 06:42:36 UTC 2011
2011/5/5 Eric Blake <eblake at redhat.com>:
> HACKING already mentions that comparisons against literal 'true'
> are unsafe; for consistency, also shorten comparisons against 'false'.
>
> * src/conf/domain_conf.c (virDomainNetDefParseXML): Simplify.
> * src/nwfilter/nwfilter_gentech_driver.c
> (virNWFilterDomainFWUpdateCB): Likewise.
> * tools/virsh.c (cmdVolDownload, vshCommandRun, vshPrintExtra):
> Likewise.
> ---
> src/conf/domain_conf.c | 2 +-
> src/nwfilter/nwfilter_gentech_driver.c | 2 +-
> tools/virsh.c | 8 ++++----
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
ACK.
Matthias
More information about the libvir-list
mailing list