[libvirt] [PATCH 2/3] lxc: driver: Convert emulator launching to virCommand
Cole Robinson
crobinso at redhat.com
Fri May 6 15:32:11 UTC 2011
On 05/05/2011 05:29 PM, Eric Blake wrote:
> On 05/05/2011 02:44 PM, Cole Robinson wrote:
>>
>> Signed-off-by: Cole Robinson <crobinso at redhat.com>
>> ---
>> src/lxc/lxc_driver.c | 186 ++++++++++----------------------------------------
>> 1 files changed, 37 insertions(+), 149 deletions(-)
>
> I love diffstats like this. Isn't it fun how much cruft virCommand removes?
>
>>
>> diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
>> index b94941d..930e445 100644
>> --- a/src/lxc/lxc_driver.c
>> +++ b/src/lxc/lxc_driver.c
>> @@ -1247,134 +1247,59 @@ static int lxcControllerStart(lxc_driver_t *driver,
>> int nveths,
>> char **veths,
>> int appPty,
>> - int logfd)
>> + int logfile)
>
> Why the rename here? But not a show-stopper.
I renamed it so I could just copy the logging code from the qemu driver
directly. I'll resend with the other comments addressed.
Thanks,
Cole
More information about the libvir-list
mailing list