[libvirt] [PATCH] maint: avoid comparisons to bool constants

Eric Blake eblake at redhat.com
Fri May 6 16:31:26 UTC 2011


On 05/06/2011 12:42 AM, Matthias Bolte wrote:
> 2011/5/5 Eric Blake <eblake at redhat.com>:
>> HACKING already mentions that comparisons against literal 'true'
>> are unsafe; for consistency, also shorten comparisons against 'false'.
>>
>> * src/conf/domain_conf.c (virDomainNetDefParseXML): Simplify.
>> * src/nwfilter/nwfilter_gentech_driver.c
>> (virNWFilterDomainFWUpdateCB): Likewise.
>> * tools/virsh.c (cmdVolDownload, vshCommandRun, vshPrintExtra):
>> Likewise.
>> ---
>>  src/conf/domain_conf.c                 |    2 +-
>>  src/nwfilter/nwfilter_gentech_driver.c |    2 +-
>>  tools/virsh.c                          |    8 ++++----
>>  3 files changed, 6 insertions(+), 6 deletions(-)
>>
> 
> ACK.

Thanks; pushed.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110506/75d3c258/attachment-0001.sig>


More information about the libvir-list mailing list