[libvirt] [RFC][PATCH 1/7] interface: add new public API

[Laine Stump]

On 05/10/2011 05:35 AM, Daniel P. Berrange wrote:
> On Mon, May 09, 2011 at 09:28:47PM +0200, Michal Privoznik wrote:
>> API agreed on in:
>> https://www.redhat.com/archives/libvir-list/2011-May/msg00026.html
>> ---
>>   include/libvirt/libvirt.h.in |    7 +++++++
>>   src/libvirt_public.syms      |    7 +++++++
>>   2 files changed, 14 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
>> index 5783303..3225294 100644
>> --- a/include/libvirt/libvirt.h.in
>> +++ b/include/libvirt/libvirt.h.in
>> @@ -1309,6 +1309,13 @@ int                     virInterfaceDestroy       (virInterfacePtr iface,
>>   int                     virInterfaceRef           (virInterfacePtr iface);
>>   int                     virInterfaceFree          (virInterfacePtr iface);
>>
>> +int                     virInterfaceChangeStart   (virConnectPtr conn,
>> +                                                   unsigned int flags);
>> +int                     virInterfaceChangeCommit  (virConnectPtr conn,
>> +                                                   unsigned int flags);
>> +int                     virInterfaceChangeRollback(virConnectPtr conn,
>> +                                                   unsigned int flags);
> I find the combination 'Start' + 'Commit' a bit unusual. I think
> it would be better named 'Begin'.

Agreed. I just mistyped in the original description that Michal was 
working from.