[libvirt] [PATCH] maint: avoid double-close bug in gnulib

Eric Blake eblake at redhat.com
Wed May 11 18:04:57 UTC 2011


On 05/10/2011 03:57 PM, Eric Blake wrote:
> Regression introduced in commit 9d8e01a1d.
> 
> * .gnulib: Update to latest, for fclose fix.
> ---
> 
> Solves the issue raised here:
> https://www.redhat.com/archives/libvir-list/2011-May/msg00580.html

I'm now pushing this under the build-breaker rule with additional gnulib
updates shown below.  That's because our recent change to require rpcgen
at bootstrap time was failing on RHEL 5.

* .gnulib 112b21e...64a5e38 (7):
  > fclose: preserve fflush errors
  > bootstrap: support a prereq of 'rpcgen -' on RHEL5
  > maint.mk: drop redundant check
  > autoupdate
  > fclose: Fix possible link error.
  > maint.mk: adjust previous commit
  > maint.mk: improve "can not" detection and generalize rule name

> 
> * .gnulib a6676cc...112b21e (19):
>   > fclose: avoid double close race when possible
>   > openat: correct new comment
>   > openat: add comments
>   > openat: reduce syscalls in first probe of /proc
>   > autoupdate
>   > maint.mk: change semantics/name of tight_scope variables
>   > maint.mk: fix oops
>   > maint.mk: tweak new rule's name not to impinge
>   > maint.mk: add a syntax-check rule to ensure tightly-scoped symbols
>   > gc: Remove gl_PREREQ_GC (not used).
>   > Comments.
>   > glob: Remove obsolete macro.
>   > intprops: Sun C 5.11 supports __typeof__
>   > intprops: switch to usual gnulib indenting and naming
>   > maint.mk: suppress "Entering/Leaving directory" diag in announcement
>   > tzset: Fix gettimeofday wrapper on Solaris 2.6.
>   > ignore-value, verify: Omit include files from lib_SOURCES.
>   > fclose: Simplify autoconf macro.
>   > canonicalize-lgpl: Fix autoconf macro ordering bug.
> 
>  .gnulib |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/.gnulib b/.gnulib
> index a6676cc..112b21e 160000
> --- a/.gnulib
> +++ b/.gnulib
> @@ -1 +1 @@
> -Subproject commit a6676cca6498ce67c5a3c8d7221b8d6c30b61dc4
> +Subproject commit 112b21e3861a4887731b61888d1388127957ba93

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110511/8823ebaf/attachment-0001.sig>


More information about the libvir-list mailing list