[libvirt] [PATCH] esx: Whitespace cleanup in the generator

Eric Blake eblake at redhat.com
Mon May 16 17:47:46 UTC 2011


On 05/01/2011 01:57 PM, Matthias Bolte wrote:
> Break long lines and change spacing of keyword arguments to match
> Python style standards better.
> 
> No functional change included.
> ---
>  src/esx/esx_vi_generator.py |  369 ++++++++++++++++++++++++++++--------------
>  1 files changed, 246 insertions(+), 123 deletions(-)

I don't know the python style standards, but I could at least review
this on the grounds of looking like safe whitespace changes.

ACK.

> @@ -830,7 +908,8 @@ class Object(Type):
>  
>                  if self.features & Object.FEATURE__LIST:
>                      source += "/* esxVI_%s_SerializeList */\n" % self.name
> -                    source += "ESX_VI__TEMPLATE__LIST__SERIALIZE(%s)\n\n" % self.name
> +                    source += "ESX_VI__TEMPLATE__LIST__SERIALIZE(%s)\n\n" \
> +                              % self.name
>  
>          # deserilaize

You may want to do a followup patch to fix typos like this.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110516/ac6e707e/attachment-0001.sig>


More information about the libvir-list mailing list