[libvirt] [PATCH 5/5] remote generator: Don't rely on $_ being stable over a large function

[Eric Blake]

On 05/15/2011 12:23 AM, Matthias Bolte wrote:
> Replace $calls{$_} with $call in the dispatch bodies generator function.
> 
> No functional change included.
> ---
>  daemon/remote_generator.pl |  100 ++++++++++++++++++++++---------------------
>  1 files changed, 51 insertions(+), 49 deletions(-)
> 
> diff --git a/daemon/remote_generator.pl b/daemon/remote_generator.pl
> index c2468b9..5725583 100755
> --- a/daemon/remote_generator.pl
> +++ b/daemon/remote_generator.pl
> @@ -272,11 +272,13 @@ elsif ($opt_b) {
>      my @keys = sort (keys %calls);
>  
>      foreach (@keys) {
> +        my $call = $calls{$_};
> +
>          # skip things which are REMOTE_MESSAGE
> -        next if $calls{$_}->{msg};
> +        next if $call->{msg};

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110516/c6217e47/attachment-0001.sig>