[libvirt] [Bug 702602] [PATCH] OpenVZ configuration files parsing

[Taisuke Yamada]

Hi.

As reported by Diego Blanco in

- https://bugzilla.redhat.com/show_bug.cgi?id=702602

commit f0443765 which replaced openvz_readline to getline(3)
broke OpenVZ driver as it changed semantics of EOF-handling
when parsing OpenVZ configuration.

There're several other issues reported with current OpenVZ driver:

  #1: unclear error message when parsing "CPUS=" line
  #2: openvz driver goes into crashing loop
  #3: "NETIF=" line in configuration is not parsed correctly
  #4: aborts even when optional parameter is missing
  #5: there's a potential memory leak

In this email, I'm sending in updated patch to fix #[145].
This patch does not fix #[23] as I haven't verified these yet,
but this at least got me to run OpenVZ on libvirt once again.

This patch applies to latest git, and I verified that both
"make check" and "make syntax-check" passes (except
for check_author_list check).

Best Regards,

> --- Comment #3 from Cole Robinson <crobinso at redhat.com> 2011-05-18 09:34:21 EDT ---
> Thanks for the report and the patch. However, libvirt devs generally don't
> review patches in bugzilla. Can you please send your patch to
> libvirt-list at redhat.com, and ensure that it applied against latest upstream,
> and that make check  and make syntax-check both pass?
>
> When the patch is applied, we can close this bug. Thanks!
>
> --
> Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug.
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt-openvz-readconfig-fix.patch
Type: text/x-patch
Size: 2196 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110519/2238a766/attachment-0001.bin>