[libvirt] [PATCH] Don't restore labels on network shares

Christian Brunner chb at muc.de
Mon May 23 20:03:58 UTC 2011


Restoring security labels on network shares doesn't work and will cause
an error. Therefore it should be skipped.

Signed-off-by: Christian Brunner <chb at muc.de>
---
 src/security/security_dac.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/src/security/security_dac.c b/src/security/security_dac.c
index fba2d1d..02c0bc1 100644
--- a/src/security/security_dac.c
+++ b/src/security/security_dac.c
@@ -213,6 +213,13 @@ virSecurityDACRestoreSecurityImageLabelInt(virSecurityManagerPtr mgr,
     if (!disk->src)
         return 0;
 
+    /* Don't restore labels on network shares */
+    if (disk->type == VIR_DOMAIN_DISK_TYPE_NETWORK) {
+            VIR_DEBUG("Skipping image label restore on %s because FS is of type network",
+                      disk->src);
+	return 0;
+    }
+
     /* If we have a shared FS & doing migrated, we must not
      * change ownership, because that kills access on the
      * destination host which is sub-optimal for the guest
-- 
1.7.1




More information about the libvir-list mailing list