[libvirt] [PATCHv2] qemu: fix typo in name - should be VHOST_NET, not VNET_HOST
Daniel P. Berrange
berrange at redhat.com
Tue May 24 14:55:28 UTC 2011
On Tue, May 24, 2011 at 08:54:34AM -0600, Eric Blake wrote:
> On 05/24/2011 08:51 AM, Daniel P. Berrange wrote:
> > On Tue, May 24, 2011 at 10:31:33AM -0400, Laine Stump wrote:
> >> NB: the enum that uses the string vnet-host (now changed to vhost-net)
> >> is used in XML, but fortunately that hasn't been in an official
> >> release yet, so it can still be fixed.
> >> ---
> >> src/qemu/qemu_capabilities.c | 4 ++--
> >> src/qemu/qemu_capabilities.h | 2 +-
> >> src/qemu/qemu_command.c | 2 +-
> >> tests/qemuhelptest.c | 8 ++++----
> >> 4 files changed, 8 insertions(+), 8 deletions(-)
> >>
> >> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> >> index 71a54a5..c69cf1d 100644
> >> --- a/src/qemu/qemu_capabilities.c
> >> +++ b/src/qemu/qemu_capabilities.c
> >> @@ -85,7 +85,7 @@ VIR_ENUM_IMPL(qemuCaps, QEMU_CAPS_LAST,
> >> "netdev",
> >>
> >> "rtc", /* 30 */
> >> - "vnet-host",
> >> + "vhost-net",
> >> "rtc-td-hack",
> >> "no-hpet",
> >> "no-kvm-pit",
> >
> > NACK. See the comment above this enum
> >
> > /* While not public, these strings must not change. They
> > * are used in domain status files which are read on
> > * daemon restarts
> > */
>
> These strings did not exist in 0.9.1. They will first appear in 0.9.2,
> which means that _now_ is the time to fix them.
Oh, I was thinking we had this in 0.9.1
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list