[libvirt] [PATCH] audit: fix minor off-by-one

[Laine Stump]

On 05/26/2011 11:11 AM, Eric Blake wrote:
> Coverity spotted this off-by-one.  Thankfully, no one in libvirt
> was ever calling virAuditSend with an argument of 3.
>
> * src/util/virtaudit.c (virAuditSend): Use correct comparison.
> ---
>   src/util/virtaudit.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/util/virtaudit.c b/src/util/virtaudit.c
> index 2f1a529..560f7b7 100644
> --- a/src/util/virtaudit.c
> +++ b/src/util/virtaudit.c
> @@ -1,7 +1,7 @@
>   /*
>    * virtaudit.c: auditing support
>    *
> - * Copyright (C) 2010 Red Hat, Inc.
> + * Copyright (C) 2010-2011 Red Hat, Inc.
>    *
>    * This library is free software; you can redistribute it and/or
>    * modify it under the terms of the GNU Lesser General Public
> @@ -123,7 +123,7 @@ void virAuditSend(const char *file ATTRIBUTE_UNUSED, const char *func,
>               [VIR_AUDIT_RECORD_RESOURCE] = AUDIT_VIRT_RESOURCE,
>           };
>
> -        if (type>  ARRAY_CARDINALITY(record_types) || record_types[type] == 0)
> +        if (type>= ARRAY_CARDINALITY(record_types) || record_types[type] == 0)
>               VIR_WARN("Unknown audit record type %d", type);
>           else if (audit_log_user_message(auditfd, record_types[type], str, NULL,
>                                           clientaddr, clienttty, success)<  0) {

ACK.