[libvirt] [PATCH] Workaround apibuild.py warnings

Matthias Bolte matthias.bolte at googlemail.com
Tue May 31 08:43:16 UTC 2011


2011/5/31 Daniel Veillard <veillard at redhat.com>:
> On Sun, May 29, 2011 at 05:14:46PM +0200, Matthias Bolte wrote:
>> Parsing ./../include/libvirt/libvirt.h
>> Misformatted macro comment for _virSchedParameter
>>   Expecting '* _virSchedParameter:' got '* virSchedParameter:'
>> Misformatted macro comment for _virBlkioParameter
>>   Expecting '* _virBlkioParameter:' got '* virBlkioParameter:'
>> Misformatted macro comment for _virMemoryParameter
>>   Expecting '* _virMemoryParameter:' got '* virMemoryParameter:'
>>
>> Replace '#define' with '# define' for the backward compatibility
>> defines to keep apibuild.py from parsing them and expecting
>> documentation comments for them.
>> ---
>>  include/libvirt/libvirt.h.in |    6 +++---
>>  1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
>> index 8058229..424e49b 100644
>> --- a/include/libvirt/libvirt.h.in
>> +++ b/include/libvirt/libvirt.h.in
>> @@ -2569,7 +2569,7 @@ typedef enum {
>>   * Provided for backwards compatibility; virTypedParameter is the
>>   * preferred alias since 0.9.2.
>>   */
>> -#define _virSchedParameter _virTypedParameter
>> +# define _virSchedParameter _virTypedParameter
>>  typedef struct _virTypedParameter virSchedParameter;
>>
>>  /**
>> @@ -2613,7 +2613,7 @@ typedef enum {
>>   * Provided for backwards compatibility; virTypedParameter is the
>>   * preferred alias since 0.9.2.
>>   */
>> -#define _virBlkioParameter _virTypedParameter
>> +# define _virBlkioParameter _virTypedParameter
>>  typedef struct _virTypedParameter virBlkioParameter;
>>
>>  /**
>> @@ -2657,7 +2657,7 @@ typedef enum {
>>   * Provided for backwards compatibility; virTypedParameter is the
>>   * preferred alias since 0.9.2.
>>   */
>> -#define _virMemoryParameter _virTypedParameter
>> +# define _virMemoryParameter _virTypedParameter
>>  typedef struct _virTypedParameter virMemoryParameter;
>
>  That's a bit odd ... it should be possibe to avoid those complaints
> from the generator, I can't look right now though
>
> Daniel

Well, yes this was more like a hackish approach. Here's a v2 that
allows apibuild.py to ignore macros like it can already ignore
functions.

Matthias
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Ignore-backward-compatibility-macros-in-apibuild.py.patch
Type: text/x-patch
Size: 1789 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110531/079a517f/attachment-0001.bin>


More information about the libvir-list mailing list