[libvirt] [PATCH v2] tests: Add more complex domain scheme test data
Eric Blake
eblake at redhat.com
Tue May 31 17:33:37 UTC 2011
On 05/31/2011 11:28 AM, Eric Blake wrote:
> This is the first test in qemuxml2argvdata that insists on
> /usr/bin/qemu-kvm instead of /usr/bin/qemu.
>
> I was about to push the "obvious" fix of s/qemu-kvm/qemu/, but that just
> papers over the real bug, which is that our testsuite depends on what is
> installed on the test machine. We need to figure out the root cause and
> make the test work even when the <emulator> tag requested by the tag
> does not exist on the machine running the test.
Perhaps using <emulator>/./qemu.sh</emulator> is the way to go for this
test (see qemuxml2argv-cpu-exact1.xml, for precedence).
On the other hand, it looks like qemuxml2argvtest is only run if qemu
was detected, which is why we have been getting away with calling the
/usr/bin/qemu binary in so many tests already, but it seems like a nicer
solution would be one where we don't have to use the external binary at all.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110531/ace8f2ca/attachment-0001.sig>
More information about the libvir-list
mailing list