[libvirt] [PATCH 1/3] Add field to virDomainObjPtr to track "tainting"

Eric Blake eblake at redhat.com
Wed May 4 14:45:53 UTC 2011


On 05/04/2011 05:28 AM, Daniel P. Berrange wrote:
> +bool virDomainObjTaint(virDomainObjPtr obj,
> +                       int taint)
> +{
> +    int flag = (1 << taint);

Undefined behavior if taint is out of bounds (>= 31).  Do we need a
sanity check, or to change the 'int taint' parameter to instead be 'enum
virDomainTaintFlags'?

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110504/cd454720/attachment-0001.sig>


More information about the libvir-list mailing list