[libvirt] [PATCHv2] storage: avoid null deref and leak on failure

Eric Blake eblake at redhat.com
Wed May 4 21:06:50 UTC 2011


On 05/04/2011 11:56 AM, Laine Stump wrote:
> On 05/04/2011 12:52 PM, Eric Blake wrote:
>> Detected by clang.  NULL deref added in commit 343a27a (Mar 11),
>> but leak of voldef present since commit 2cd9b2d (Apr 09).
>>
>> * src/storage/storage_driver.c (storageVolumeCreateXML): Don't
>> leak voldef or dereference null volobj.
>> ---
>>
>> v2: don't leave pool->volumes.objs pointing to stale memory on failure
>>
> ACK.

Thanks; pushed.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110504/7b5b2b49/attachment-0001.sig>


More information about the libvir-list mailing list