[libvirt] [PATCH 3/3] Make QEMU migration use cached qemu capabilities data
Eric Blake
eblake at redhat.com
Thu May 5 11:43:27 UTC 2011
On 05/04/2011 07:49 AM, Daniel P. Berrange wrote:
> * src/qemu/qemu_migration.c, src/qemu/qemu_migration.h: Remove
> qemuCaps parameters & use cached data
> * src/qemu/qemu_driver.c: Don't create & pass qemuCaps to
> migration methods
> ---
> +++ b/src/qemu/qemu_migration.h
> @@ -61,7 +61,6 @@ virDomainPtr qemuMigrationFinish(struct qemud_driver *driver,
>
>
> int qemuMigrationToFile(struct qemud_driver *driver, virDomainObjPtr vm,
> - virBitmapPtr qemuCaps,
> int fd, off_t offset, const char *path,
> const char *compressor,
> bool is_reg, bool bypassSecurityDriver)
Ouch - we changed the offset of parameters within the signature, but not
the offset of the corresponding ATTRIBUTE_NONNULL that goes with them.
Oh, you already saw this.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110505/9193746f/attachment-0001.sig>
More information about the libvir-list
mailing list