[libvirt] [PATCH 1/3] command: Add virCommandEnvAddFormat
Eric Blake
eblake at redhat.com
Thu May 5 21:19:46 UTC 2011
On 05/05/2011 02:44 PM, Cole Robinson wrote:
> Similar to virCommandArgAddFormat. We will use this shortly.
>
> Signed-off-by: Cole Robinson <crobinso at redhat.com>
> ---
> src/libvirt_private.syms | 1 +
> src/util/command.c | 30 ++++++++++++++++++++++++++++++
> src/util/command.h | 7 +++++++
> 3 files changed, 38 insertions(+), 0 deletions(-)
Looks fine as-is, but now that we have it, I'm wondering if we should
simplify:
void
virCommandAddEnvPair(virCommandPtr cmd, const char *name, const char *value)
{
virCommandAddEnvFormat(cmd, "%s=%s", name, value);
}
ACK
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110505/973274ad/attachment-0001.sig>
More information about the libvir-list
mailing list