[libvirt] [PATCH] remote generator: Add skipgen/autogen flags to .x files
Matthias Bolte
matthias.bolte at googlemail.com
Thu May 12 06:45:49 UTC 2011
2011/5/12 Eric Blake <eblake at redhat.com>:
> On 05/11/2011 01:28 PM, Matthias Bolte wrote:
>> Make procedure parsing more robust, by allowing arbitrary
>> amounts of whitespaces.
>>
>> Also make some error messages more verbose.
>> ---
>> cfg.mk | 2 +-
>> daemon/remote_generator.pl | 165 ++++-----------
>> src/remote/qemu_protocol.x | 5 +-
>> src/remote/remote_protocol.x | 463 +++++++++++++++++++++---------------------
>> 4 files changed, 282 insertions(+), 353 deletions(-)
>>
>> diff --git a/cfg.mk b/cfg.mk
>> index 9ee0dd0..f0ca000 100644
>> --- a/cfg.mk
>> +++ b/cfg.mk
>> @@ -614,7 +614,7 @@ exclude_file_name_regexp--sc_prohibit_asprintf = \
>> exclude_file_name_regexp--sc_prohibit_can_not = ^po/
>>
>> exclude_file_name_regexp--sc_prohibit_close = \
>> - (\.py$$|^docs/|(src/util/files\.c|src/libvirt\.c)$$)
>> + (\.py$$|^docs/|(src/util/files\.c|src/libvirt\.c|daemon/remote_generator\.pl)$$)
>
> How about we just exempt _all_ .pl, like we did for .py? Really, the
> rule for requiring VIR_CLOSE is intended only for C sources.
>
> (\.p[yl]$$|^docs/|(src/util/files\.c|src/libvirt\.c)$$)
>
>> - REMOTE_PROC_DOMAIN_INJECT_NMI = 210
>> + /* Each function must have a two-word comment. The first word is
>> + * whether remote_generator.pl handles daemon, the second whether
>> + * it handles src/remote. */
>> + REMOTE_PROC_OPEN = 1, /* skipgen skipgen */
>
>> + REMOTE_PROC_DOMAIN_INJECT_NMI = 210 /* autogen autogen */
>>
>> /*
>> * Notice how the entries are grouped in sets of 10 ?
>
> Might I suggest repeating the comment about the two-word comment at the
> bottom of the list? After all, you don't want to have to scroll back
> through 210+ lines just to remind yourself which word applies to which
> generator, and we only ever add to the bottom of the list.
>
> ACK with those nits fixed.
>
Thanks, fixed and pushed.
Matthias
More information about the libvir-list
mailing list