[libvirt] [PATCH 6/7] libxl: Convert to virDomainEventState

Cole Robinson crobinso at redhat.com
Fri May 13 17:26:44 UTC 2011


On 05/13/2011 01:18 PM, Eric Blake wrote:
> On 05/12/2011 11:14 AM, Cole Robinson wrote:
>>
>> Signed-off-by: Cole Robinson <crobinso at redhat.com>
>> ---
>>  src/libxl/libxl_conf.h   |    6 +---
>>  src/libxl/libxl_driver.c |   80 +++++++++++++--------------------------------
>>  2 files changed, 24 insertions(+), 62 deletions(-)
> 
> The conversion wasn't complete:
> 
>   CC     libvirt_driver_libxl_la-libxl_driver.lo
> libxl/libxl_driver.c: In function 'libxlDomainEventFlush':
> libxl/libxl_driver.c:136:30: error: 'libxmlDomainEventDispatchFunc'
> undeclared (first use in this function)
> libxl/libxl_driver.c:136:30: note: each undeclared identifier is
> reported only once for each function it appears in
> libxl/libxl_driver.c: In function 'libxlShutdown':
> libxl/libxl_driver.c:689:29: error: 'privconn' undeclared (first use in
> this function)
> libxl/libxl_driver.c: In function 'libxlStartup':
> libxl/libxl_driver.c:802:57: error: 'libxml_driver' undeclared (first
> use in this function)
> cc1: warnings being treated as errors
> libxl/libxl_driver.c: At top level:
> libxl/libxl_driver.c:117:1: error: 'libxlDomainEventDispatchFunc'
> defined but not used [-Wunused-function]
> 

Urgh, yeah, thought I was actually building the driver but clearly was not.

Attached patch should fix the breakage, can you test if it works?

Thanks,
Cole
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-libxl-breakage.patch
Type: text/x-patch
Size: 1448 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110513/6e252c6e/attachment-0001.bin>


More information about the libvir-list mailing list