[libvirt] [PATCH] qemudDomainMemoryPeek: chown temporary file to qemu.qemu.

[Daniel P. Berrange]

On Fri, May 20, 2011 at 04:19:55PM +0100, Richard W.M. Jones wrote:
> On Fri, May 20, 2011 at 04:02:41PM +0100, Daniel P. Berrange wrote:
> > On Fri, May 20, 2011 at 03:57:03PM +0100, Richard W.M. Jones wrote:
> > > On Fri, May 20, 2011 at 03:40:35PM +0100, Daniel P. Berrange wrote:
> > > > I think we likely need  /var/cache/libvirt to be 0711 so that
> > > > QEMU can access directories below it, but not actually read it.
> > > 
> > > 0711 does indeed work fine.  However, where/what sets this?
> > 
> > The RPM specfile %files section is in charge.
> 
> OK, please see the attached patch.
> 
> Rich.
> 
> -- 
> Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
> virt-p2v converts physical machines to virtual machines.  Boot with a
> live CD or over the network (PXE) and turn machines into Xen guests.
> http://et.redhat.com/~rjones/virt-p2v

> From ee9ceb3295e8e68da4c5838c57cc3c1e3a5dccfb Mon Sep 17 00:00:00 2001
> From: Richard W.M. Jones <rjones at redhat.com>
> Date: Fri, 20 May 2011 16:18:11 +0100
> Subject: [PATCH] libvirt.spec: /var/cache/libvirt should be 0711.
> 
> This allows qemu to create files in /var/cache/libvirt/qemu/, and
> specifically is required to fix virDomainMemoryPeek.
> ---
>  libvirt.spec.in |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 8a6912f..3ce9ebe 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -932,7 +932,7 @@ fi
>  
>  %dir %attr(0711, root, root) %{_localstatedir}/lib/libvirt/images/
>  %dir %attr(0711, root, root) %{_localstatedir}/lib/libvirt/boot/
> -%dir %attr(0700, root, root) %{_localstatedir}/cache/libvirt/
> +%dir %attr(0711, root, root) %{_localstatedir}/cache/libvirt/
>  
>  %if %{with_qemu}
>  %dir %attr(0700, root, root) %{_localstatedir}/run/libvirt/qemu/

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|