[libvirt] [PATCH 4/4] Remove unused 'target' field in virDomainHostdevDef

Daniel P. Berrange berrange at redhat.com
Fri May 27 12:09:10 UTC 2011


The virDomainHostdevDef struct contains a 'char *target'
field. This is set to 'NULL' when parsing XML and never
used / set anywhere else. Clearly it is bogus & unused

* src/conf/domain_conf.c, src/conf/domain_conf.h: Remove
  target from virDomainHostdevDef
---
 src/conf/domain_conf.c |    2 --
 src/conf/domain_conf.h |    1 -
 2 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index a9a4655..5412b7a 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -890,7 +890,6 @@ void virDomainHostdevDefFree(virDomainHostdevDefPtr def)
     if (!def)
         return;
 
-    VIR_FREE(def->target);
     virDomainDeviceInfoClear(&def->info);
     VIR_FREE(def);
 }
@@ -4771,7 +4770,6 @@ virDomainHostdevDefParseXML(const xmlNodePtr node,
         virReportOOMError();
         return NULL;
     }
-    def->target = NULL;
 
     mode = virXMLPropString(node, "mode");
     if (mode) {
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index 47d17dd..181226d 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -792,7 +792,6 @@ struct _virDomainHostdevDef {
             int dummy;
         } caps;
     } source;
-    char* target;
     int bootIndex;
     virDomainDeviceInfo info; /* Guest address */
 };
-- 
1.7.4.4




More information about the libvir-list mailing list