[libvirt] [PATCHv5 0/3] Add VIR_TYPED_PARAM_STRING

Eric Blake eblake at redhat.com
Tue Nov 1 23:47:39 UTC 2011


This builds on v4:
https://www.redhat.com/archives/libvir-list/2011-October/msg00446.html

It only implements the front end of supporting typed strings across
an RPC call; I'm still working on refactoring the back half of the
v4 series to actually wire up blkio device weights to be the first
use that actually sends a string, but wanted to get the review
started on these now.

Changes from v4:
Added a driver feature bit.  With that, it is no longer necessary
to set a flag when setting parameters (libvirt.c rejects attempts
for a new client to send strings to an old server lacking the
feature), and getting strings no longer needs user interactions
(the user does not have to worry about the flag bit; either the
client is too old so the flag is not set, or the client is
new enough and libvirt.c probes to see if the driver supports
things to auto-set the flag; also, libvirt.c takes care of
filtering out strings on the server side before returning so
that the drivers do not have to pay much attention to the flag).

Eric Blake (3):
  API: add VIR_TYPED_PARAM_STRING
  API: remote support for VIR_TYPED_PARAM_STRING
  API: add trivial qemu support for VIR_TYPED_PARAM_STRING

 daemon/remote.c              |   33 ++++++++++--
 include/libvirt/libvirt.h.in |   28 ++++++++++-
 src/libvirt.c                |  119 +++++++++++++++++++++++++++++++++++++-----
 src/libvirt_internal.h       |    9 +++-
 src/libvirt_private.syms     |    1 +
 src/qemu/qemu_driver.c       |   24 +++++++--
 src/remote/remote_driver.c   |   28 +++++++++-
 src/remote/remote_protocol.x |    2 +
 src/remote_protocol-structs  |    2 +
 src/rpc/gendispatch.pl       |    3 +-
 src/util/util.c              |   14 +++++
 src/util/util.h              |    2 +
 12 files changed, 237 insertions(+), 28 deletions(-)

-- 
1.7.4.4




More information about the libvir-list mailing list