[libvirt] [PATCHv2] build: fix build on platforms without ptsname_r

Eric Blake eblake at redhat.com
Mon Nov 7 16:44:24 UTC 2011


On 11/07/2011 08:18 AM, Daniel P. Berrange wrote:
> On Fri, Nov 04, 2011 at 08:06:05PM -0600, Eric Blake wrote:
>> MacOS lacks ptsname_r, and gnulib doesn't (yet) provide it.
>> But we can avoid it altogether, by using gnulib openpty()
>> instead.  Note that we do _not_ want the pt_chown module;
>> all systems that we currently port to can either properly do
>> openpty() and/or grantpt(), or lack ptys altogether; we are
>> not porting to any system that requires us to deal with the
>> hassle of installing a setuid pt_chown helper just to satisfy
>> gnulib's ability to provide openpty() on even more platforms.
>>
>> * .gnulib: Update to latest, for openpty fixes
>> * bootstrap.conf (gnulib_modules): Add openpty, ttyname_r.
>> (gnulib_tool_option_extras): Exclude pt_chown module.
>> * src/util/util.c (virFileOpenTty): Rewrite in terms of openpty
>> and ttyname_r.
>> * src/util/util.h (virFileOpenTtyAt): Delete dead prototype.
>> ---
>>
>
> ACK

Thanks; pushed.  I tweaked the commit message slightly to hopefully make 
it a bit clearer that openpty() includes the actions of grantpt() under 
the hood, and that the exclusion of pt_chown only affects platforms that 
lack both openpty() and grantpt().

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list