[libvirt] [PATCH] qemu: Fix improper error message for disk detaching

Osier Yang jyang at redhat.com
Wed Nov 9 05:59:54 UTC 2011


On 11/09/2011 01:02 PM, Xu He Jie wrote:
> 于 2011年11月09日 12:27, Osier Yang 写道:
>> s/virDomainDeviceTypeToString/virDomainDiskDeviceTypeToString/
>>
>> Report by Xu He Jie<xuhj at linux.vnet.ibm.com>
>> ---
>>   src/qemu/qemu_driver.c |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
>> index 118197a..cee689b 100644
>> --- a/src/qemu/qemu_driver.c
>> +++ b/src/qemu/qemu_driver.c
>> @@ -5212,8 +5212,8 @@ qemuDomainDetachDeviceDiskLive(struct 
>> qemud_driver *driver,
>>           break;
>>       default:
>>           qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED,
>> -                        _("device type '%s' cannot be detached"),
>> -                        virDomainDeviceTypeToString(dev->type));
>> +                        _("disk device type '%s' cannot be detached"),
>> +                        virDomainDiskDeviceTypeToString(dev->type));
> 's/dev->type/disk->device/' will be right.:)

Oh, yes, I pushed with this fix under trival rule, thanks.

Osier




More information about the libvir-list mailing list